Skip to content

Conversation

@gdostie
Copy link
Collaborator

@gdostie gdostie commented Dec 30, 2025

Proposed Changes

This pull request introduces several improvements to the Header component and its related subcomponents in the Plasma Mantine library, focusing on standardizing component display names, enhancing Figma integration, and simplifying Storybook stories. The changes improve maintainability, developer experience, and tooling compatibility.

Component API and Display Name Standardization:

  • Added or updated displayName properties for Header and all its subcomponents to follow a consistent naming convention (e.g., 'Header.Breadcrumbs', 'Header.DocAnchor') for better debugging and React DevTools support. [1] [2] [3] [4] [5] [6]

Figma Integration Improvements:

  • Updated packages/figma/src/Header.figma.tsx to provide a more complete and realistic Figma code example, including mappings for header props and usage of subcomponents like Header.Breadcrumbs, Header.DocAnchor, and Header.Right. This enhances the design-development workflow.

Storybook Story Simplification:

  • Refactored Header stories in Storybook to use a single, more flexible Demo story that supports props for breadcrumbs, doc anchor, and actions, replacing multiple redundant stories and improving maintainability.

Type and Formatting Consistency:

  • Improved type definitions and formatting for props in several subcomponents, making the codebase more readable and aligned with best practices. [1] [2] [3]

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@github-actions
Copy link

@github-actions
Copy link

@gdostie gdostie marked this pull request as ready for review December 30, 2025 16:53
@gdostie gdostie requested a review from a team as a code owner December 30, 2025 16:53
@gdostie gdostie requested review from FelixBlaisThon, GermainBergeron and Copilot and removed request for a team and Copilot December 30, 2025 16:53
@gdostie gdostie merged commit 9df14c9 into master Jan 7, 2026
9 checks passed
@gdostie gdostie deleted the DS-38-header-storybook branch January 7, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants