feat: component Header storybook #4268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request introduces several improvements to the
Headercomponent and its related subcomponents in the Plasma Mantine library, focusing on standardizing component display names, enhancing Figma integration, and simplifying Storybook stories. The changes improve maintainability, developer experience, and tooling compatibility.Component API and Display Name Standardization:
displayNameproperties forHeaderand all its subcomponents to follow a consistent naming convention (e.g.,'Header.Breadcrumbs','Header.DocAnchor') for better debugging and React DevTools support. [1] [2] [3] [4] [5] [6]Figma Integration Improvements:
packages/figma/src/Header.figma.tsxto provide a more complete and realistic Figma code example, including mappings for header props and usage of subcomponents likeHeader.Breadcrumbs,Header.DocAnchor, andHeader.Right. This enhances the design-development workflow.Storybook Story Simplification:
Headerstories in Storybook to use a single, more flexibleDemostory that supports props for breadcrumbs, doc anchor, and actions, replacing multiple redundant stories and improving maintainability.Type and Formatting Consistency:
Potential Breaking Changes
Acceptance Criteria