-
Notifications
You must be signed in to change notification settings - Fork 15
feat: component MultiSelect storybook #4271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1ef40a to
e5aae84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces Storybook documentation and Figma integration for the existing MultiSelect component in the Plasma design system. The changes ensure proper interactive documentation through Storybook stories and design-to-code consistency via Figma Code Connect.
- Added Storybook story with comprehensive controls for MultiSelect component features
- Integrated MultiSelect with Figma using code-connect for design consistency
- Configured props mapping between Figma design properties and component props
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/storybook/src/form/MultiSelect.stories.tsx | Adds Storybook story with controls for searchable, clearable, and other MultiSelect props |
| packages/figma/src/MultiSelect.figma.tsx | Connects MultiSelect to Figma design with props mapping for label, description, placeholder, error, and state variants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e5aae84 to
b179783
Compare
Proposed Changes
This pull request introduces the
MultiSelectcomponent to the Plasma design system, integrating it across Figma, Mantine, and Storybook environments. The changes ensure that the component is properly exported, connected to Figma for design consistency, and documented with interactive examples in Storybook.Component integration and exports:
MultiSelectcomponent export inpackages/mantine/src/components/MultiSelect/MultiSelect.ts, setting its display name for better debugging and documentation.Figma integration:
MultiSelectcomponent to Figma using@figma/code-connect, mapping relevant props such aslabel,description,placeholder,error,required,disabled, andreadOnlyfor design-development consistency inpackages/figma/src/MultiSelect.figma.tsx.Storybook documentation:
MultiSelectinpackages/storybook/src/form/MultiSelect.stories.tsx, including example usage, default props, and controls for key features likesearchableandclearable.Potential Breaking Changes
Acceptance Criteria