feat: component CodeEditor storybook #4274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdostie
requested review from
FelixBlaisThon and
GermainBergeron
and removed request for
a team
FelixBlaisThon
approved these changes
Jan 6, 2026
Collaborator
FelixBlaisThon
left a comment
FelixBlaisThon
left a comment
There was a problem hiding this comment.
TextInput conflicts are in a lot of your PR since your last merge 🩹
gdostie
force-pushed
the
DS-30-codeeditor
branch
from
48ad5d5 to
da2cd10
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the CodeEditor Storybook stories from multiple hardcoded examples to a single configurable Demo story that uses Storybook's controls and shared argument types. This improves maintainability and provides a more interactive way to test the component.
Key changes:
- Consolidates 6 separate stories (Default, Disabled, Error, GraphQL, Python, XML) into a single Demo story
- Adopts shared InputWrapperArgs and InputWrapperArgTypes for standardized input props
- Removes form validation logic from stories, focusing purely on component configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gdostie
force-pushed
the
DS-30-codeeditor
branch
from
da2cd10 to
763b13a
Compare
gdostie
force-pushed
the
DS-30-codeeditor
branch
from
763b13a to
c1118ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request refactors the Storybook stories for the
CodeEditorcomponent to use a more standardized and maintainable approach. Instead of multiple custom stories with internal form logic, it now uses shared input arguments and argTypes, and consolidates the stories into a single, configurable demo.Storybook story simplification and standardization:
Demostory that leverages Storybook's controls for props, making it easier to test different configurations interactively.InputWrapperArgsandInputWrapperArgTypesto standardize input props and controls across stories.metaobject to include default args and argTypes for easier customization and better documentation.CodeEditorcomponent itself.Potential Breaking Changes
Acceptance Criteria