fix: handle errors #116
Merged
fix: handle errors #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce improved error handling and robustness to the message processing flow in the Telegram app's main module. A new helper function, Changes
Sequence Diagram(s)sequenceDiagram
participant Consumer as Message Consumer
participant Parser as parseNewMessage
participant Handler as onNewMessage
participant Subscriptions as Subscription Service
participant Logger as Logger
Consumer->>Parser: parseNewMessage(msg)
alt Parsing fails
Parser->>Logger: Log parsing error
Parser-->>Consumer: return null
Consumer-->>Logger: Log processing skipped
else Parsing succeeds
Parser-->>Handler: Notification
Handler->>Subscriptions: Fetch subscriptions
alt Fetch fails
Subscriptions-->>Logger: Log fetch error
Handler-->>Consumer: return null
else No subscriptions
Handler-->>Logger: Log no subscriptions
else Subscriptions found
Handler->>...: Process notification
end
end
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
anxolin
commented
Apr 16, 2025
| onNewMessage(channel, msg); | ||
| onNewMessage(channel, msg).catch((error) => | ||
| console.error('Error processing queue message', error) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
this is the key part. Not throw if message is wrong
alfetopito
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the error that's making crashlooping in prod. We just crash if the queue message has not the right format
Also, prints some useful info on which part throws an error
Summary by CodeRabbit
Bug Fixes
Chores