feat: notifications without account #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
May 13, 2024
| MODULE_ID, | ||
| { | ||
| start: 0, | ||
| limit: 50, |
Contributor
There was a problem hiding this comment.
what's the plan for the hardcoded 50
Contributor
Author
There was a problem hiding this comment.
I would even keep it as it is.
We could add pagination and so on, but...will we really need it?
I think the main use-case of the notifications is to notify users about something new which is relevant only for the nearest feature.
As a user I would read even only the last 3-5 notifications.
But this is only my assumption, I'm open for any proposal.
Contributor
There was a problem hiding this comment.
Okay, lets keep it for now them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.