refactoring: notifications #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
approved these changes
May 15, 2024
Contributor
alfetopito
left a comment
alfetopito
left a comment
There was a problem hiding this comment.
Thank you!
Will you also send a PR to bff to adjust to these changes?
anxolin
approved these changes
May 16, 2024
Contributor
anxolin
left a comment
anxolin
left a comment
There was a problem hiding this comment.
Looks great! thanks for addressing them
…oring/notifications # Conflicts: # src/extensions/documentation/documentation/1.0.0/full_documentation.json
alfetopito
approved these changes
Jun 19, 2024
Contributor
|
This PR needs to go coordinated now with CoW Swap? |
Contributor
Author
|
@anxolin I kept the old route for backward-compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE ONLY AFTER KNOWLEDGE SHARING SESSION!!!
Addressed all comments from the previous PRs with notifications changes.
Mostly renamed routes and adjusted collections flags (
required,draftAndPublish, etc.)