fix: search notifications for account with any case #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
Jun 19, 2024
| notification_template: notificationsTemplateFilter(push) | ||
| $or: [ | ||
| { account, notification_template: templateFilter }, | ||
| { account: account.toLowerCase(), notification_template: templateFilter }, |
Contributor
There was a problem hiding this comment.
nit: why not just to lowecase it when we save it in the db so we don't need to implement the OR?
Contributor
Author
There was a problem hiding this comment.
It can be added from admin panel UI and we can't control the value there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/notification-listendpoint was not considering different cases foraccountparameter.Now it select notifications for both original and lowercased.