chore(eslint): restrict modules imports inside common dir

apps/cowswap-frontend/src/common/containers/CoWAmmBanner/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback } from 'react'
 
 import { useCowAnalytics } from '@cowprotocol/analytics'

apps/cowswap-frontend/src/common/containers/CoWAmmBanner/types.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { LpToken } from '@cowprotocol/common-const'
 import { LpTokenProvider } from '@cowprotocol/types'
 import { BigNumber } from '@ethersproject/bignumber'

apps/cowswap-frontend/src/common/containers/OrderHooksDetails/HookItem/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useState } from 'react'
 
 import { CowHookDetails, HookToDappMatch } from '@cowprotocol/hook-dapp-lib'

apps/cowswap-frontend/src/common/containers/OrderHooksDetails/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { ReactElement, useEffect, useMemo, useState } from 'react'
 
 import { cowAppDataLatestScheme } from '@cowprotocol/cow-sdk'

apps/cowswap-frontend/src/common/hooks/useCancelOrder/onChainCancellation.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { GPv2Settlement, CoWSwapEthFlow } from '@cowprotocol/abis'
 import { calculateGasMargin } from '@cowprotocol/common-utils'
 import { BigNumber } from '@ethersproject/bignumber'
@@ -25,7 +26,7 @@ export interface OnChainCancellation {
 
 export async function getEthFlowCancellation(
   ethFlowContract: CoWSwapEthFlow,
-  order: Order
+  order: Order,
 ): Promise<OnChainCancellation> {
   const cancelOrderParams = {
     buyToken: order.buyToken,
@@ -43,7 +44,7 @@ export async function getEthFlowCancellation(
     logTradeFlowError(
       LOG_LABEL,
       `Error estimating invalidateOrder gas. Using default ${CANCELLATION_GAS_LIMIT_DEFAULT}`,
-      error
+      error,
     )
     return CANCELLATION_GAS_LIMIT_DEFAULT
   })
@@ -72,7 +73,7 @@ export async function getOnChainCancellation(contract: GPv2Settlement, order: Or
     logTradeFlowError(
       LOG_LABEL,
       `Error estimating invalidateOrder gas. Using default ${CANCELLATION_GAS_LIMIT_DEFAULT}`,
-      error
+      error,
     )
     return CANCELLATION_GAS_LIMIT_DEFAULT
   })

apps/cowswap-frontend/src/common/hooks/useCancelOrder/useGetOnChainCancellation.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback } from 'react'
 
 import { getIsNativeToken } from '@cowprotocol/common-utils'

apps/cowswap-frontend/src/common/hooks/useCancelOrder/useSendOnChainCancellation.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback } from 'react'
 
 import { getIsNativeToken } from '@cowprotocol/common-utils'

apps/cowswap-frontend/src/common/hooks/useConvertUsdToTokenValue.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { USDC } from '@cowprotocol/common-const'
 import { getWrappedToken, tryParseCurrencyAmount } from '@cowprotocol/common-utils'
 import { SupportedChainId } from '@cowprotocol/cow-sdk'

apps/cowswap-frontend/src/common/hooks/useEnhancedActivityDerivedState.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { SupportedChainId } from '@cowprotocol/cow-sdk'

apps/cowswap-frontend/src/common/hooks/useGetExecutedBridgeSummary.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { useTokenByAddress } from '@cowprotocol/tokens'

apps/cowswap-frontend/src/common/hooks/useGetMarketDimension.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { useTradeTypeInfo } from 'modules/trade'

apps/cowswap-frontend/src/common/hooks/useGetSurplusFiatValue.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { MIN_FIAT_SURPLUS_VALUE, MIN_FIAT_SURPLUS_VALUE_MODAL, MIN_SURPLUS_UNITS } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/hooks/useOnSelectNetwork.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback } from 'react'
 
 import { getChainInfo } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/hooks/useRateInfoParams.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback } from 'react'
 
 import { tryParseCurrencyAmount } from '@cowprotocol/common-utils'
@@ -14,7 +15,7 @@ import { RateInfoParams } from 'common/pure/RateInfo'
 
 export function useRateInfoParams(
   inputCurrencyAmount: Nullish<CurrencyAmount<Currency>>,
-  outputCurrencyAmount: Nullish<CurrencyAmount<Currency>>
+  outputCurrencyAmount: Nullish<CurrencyAmount<Currency>>,
 ): RateInfoParams {
   const { chainId } = useWalletInfo()
 
@@ -26,15 +27,15 @@ export function useRateInfoParams(
 
       return (invert ? activeRate.invert() : activeRate).toSignificant(18)
     },
-    [activeRate]
+    [activeRate],
   )
 
   const {
     inputAmount: { value: invertedActiveRateFiatAmount },
     outputAmount: { value: activeRateFiatAmount },
   } = useTradeUsdAmounts(
     tryParseCurrencyAmount(parseRate(true), inputCurrencyAmount?.currency || undefined),
-    tryParseCurrencyAmount(parseRate(false), outputCurrencyAmount?.currency || undefined)
+    tryParseCurrencyAmount(parseRate(false), outputCurrencyAmount?.currency || undefined),
   )
 
   return useSafeMemoObject({

apps/cowswap-frontend/src/common/hooks/useSwapAndBridgeContext.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { getChainInfo, TokenWithLogo } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/hooks/useSwapAndBridgeOverview.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { getChainInfo, TokenWithLogo } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/hooks/useSwapResultsContext.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useMemo } from 'react'
 
 import { TokenWithLogo } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/pure/CoWAmmBannerContent/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import React, { useCallback, useMemo, useRef } from 'react'
 
 import { isTruthy } from '@cowprotocol/common-utils'

apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContentShell.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import React, { ReactNode } from 'react'
 
 import { Command } from '@cowprotocol/types'

apps/cowswap-frontend/src/common/pure/CurrencyInputPanel/CurrencyInputPanel.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import React, { ReactNode, useCallback, useEffect, useMemo, useState } from 'react'
 
 import { NATIVE_CURRENCIES } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/pure/CurrencyInputPanel/types.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { ReactNode } from 'react'
 
 import { Currency, CurrencyAmount } from '@uniswap/sdk-core'

apps/cowswap-frontend/src/common/pure/ExecutionPrice/hooks/useExecutionPriceFiat.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { rawToTokenAmount } from '@cowprotocol/common-utils'
 import { Currency, CurrencyAmount, Price } from '@uniswap/sdk-core'
 
@@ -8,13 +9,13 @@ function getPriceQuoteAmount(price: Price<Currency, Currency>, isInverted: boole
 
   return CurrencyAmount.fromRawAmount(
     executionPrice.baseCurrency,
-    rawToTokenAmount(1, executionPrice.baseCurrency.decimals)
+    rawToTokenAmount(1, executionPrice.baseCurrency.decimals),
   )
 }
 
 export function useExecutionPriceFiat(
   executionPrice: Price<Currency, Currency> | null,
-  isInverted: boolean
+  isInverted: boolean,
 ): CurrencyAmount<Currency> | null {
   const amount = executionPrice ? getPriceQuoteAmount(executionPrice, isInverted) : undefined
 

apps/cowswap-frontend/src/common/pure/ReceiveAmount/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { ReactNode } from 'react'
 
 import { TokenAmount } from '@cowprotocol/ui'

apps/cowswap-frontend/src/common/pure/ReceiveAmountInfo/index.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import React, { ReactNode } from 'react'
 
 import { isFractionFalsy } from '@cowprotocol/common-utils'

apps/cowswap-frontend/src/common/updaters/BridgingEnabledUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useEffect } from 'react'
 
 import { useSetIsBridgingEnabled } from '@cowprotocol/common-hooks'

apps/cowswap-frontend/src/common/updaters/SentryUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useEffect } from 'react'
 
 import { useIsWindowVisible } from '@cowprotocol/common-hooks'

apps/cowswap-frontend/src/common/updaters/WidgetTokensUpdater.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { ReactNode } from 'react'
 
 import { useCowAnalytics } from '@cowprotocol/analytics'

apps/cowswap-frontend/src/common/updaters/orders/CancelledOrdersUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useCallback, useEffect, useRef } from 'react'
 
 import { CANCELLED_ORDERS_PENDING_TIME } from '@cowprotocol/common-const'

apps/cowswap-frontend/src/common/updaters/orders/OrdersFromApiUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useSetAtom } from 'jotai'
 import { useCallback, useEffect, useMemo, useRef } from 'react'
 

apps/cowswap-frontend/src/common/updaters/orders/PendingOrdersUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useSetAtom } from 'jotai'
 import { useCallback, useEffect, useMemo, useRef } from 'react'
 

apps/cowswap-frontend/src/common/updaters/orders/SpotPricesUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useSetAtom } from 'jotai'
 import { useEffect, useMemo } from 'react'
 

apps/cowswap-frontend/src/common/updaters/orders/UnfillableOrdersUpdater/hooks/useUpdateIsUnfillableFlag.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useSetAtom } from 'jotai'
 import { useCallback } from 'react'
 

apps/cowswap-frontend/src/common/updaters/orders/UnfillableOrdersUpdater/updaters/UnfillableOrderUpdater.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { useAtom, useSetAtom } from 'jotai'
 import { useRef } from 'react'
 

apps/cowswap-frontend/src/common/utils/doesOrderHavePermit.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-restricted-imports */ // TODO: Don't use 'modules' import
 import { doesHookHavePermit } from '@cowprotocol/hook-dapp-lib'
 
 import { getAppDataHooks } from 'modules/appData'

eslint.config.js

@@ -226,6 +226,28 @@ module.exports = [
       ],
     },
   },
+  /**
+   * Restrict modules/** imports inside common/** dir
+   * @see CONTRIBUTING.md
+   */
+  {
+    files: ['apps/cowswap-frontend/src/common/**/*.{ts,tsx,js,jsx}'],
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          paths: [
+            {
+              name: 'cowswap-frontend/modules',
+              message: 'Do not import from modules inside common dir.',
+            },
+          ],
+          patterns: ['modules/*'],
+        },
+      ],
+    },
+  },
+
   // Tests
   {
     files: ['**/*.test.{ts,tsx,js,jsx}'],

libs/wallet-provider/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": ["../../.eslintrc.json"],
+  "extends": ["../../eslint.config.js"],
   "ignorePatterns": ["!**/*"],
   "overrides": [
     {