Changes done for the last evaluation #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Feb 16, 2023
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
Seems good, although why would gas prices be null?
| @@ -1,6 +1,6 @@ | |||
| UNION_RAW_DATA_JOINED_WITH_PARAMETER = """with raw_data as ( | |||
| select pa.uid, sell_amount, buy_amount, executed_sell_amount, executed_buy_amount, exchange, name, data, output_value_usd, gas_cost_usd_from_trader_contract, gas_cost_usd_from_trace_callMany, gas_price, sell_token_price, buy_token_price, eth_price, block_number from exchange prd inner join parameters pa on pa.uid = prd.uid | |||
There was a problem hiding this comment.
Not relevant to this or, but this line is way too long. Is there any other fields that could be null we maybe want to exclude?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes dones for this evaluation:
https://docs.google.com/document/d/1jYOe5_SyvIxIRqXJ9bEoiWexBFP2pbhENDduENILGTA/edit#heading=h.t3w3qalgvh6v
Considering more data and avoiding NaN values