Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@bram-vdberg
Copy link
Collaborator

@bram-vdberg bram-vdberg commented Nov 6, 2024

This PR adds a setup.py file so that the dune-sync repo can be installed with pip using pip install git+https://github.com/cowprotocol/dune-sync.git@<branch-name>. This can be tested with: pip install git+https://github.com/cowprotocol/dune-sync.git@setup_pip.

@bram-vdberg bram-vdberg marked this pull request as ready for review November 6, 2024 12:49
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that installing works. Not sure how to test if what is installed actually works.

@fhenneke
Copy link
Contributor

fhenneke commented Nov 8, 2024

I checked that installing works. How can I check that the installed package is working as expected? Running from dune_sync import main gives the error ModuleNotFoundError: No module named 'dotenv'. As if dependencies have to installed separately.

@bram-vdberg
Copy link
Collaborator Author

I checked that installing works. How can I check that the installed package is working as expected? Running from dune_sync import main gives the error ModuleNotFoundError: No module named 'dotenv'. As if dependencies have to installed separately.

I set it up without the requirements, assuming that the person doing the pip install would do that. I updated it to automatically install the prod requirements.txt as dependencies when you install it with PIP.

@harisang
Copy link
Contributor

Shouldn't the readme file be updated as well here?

@bram-vdberg bram-vdberg marked this pull request as draft November 11, 2024 07:04
@bram-vdberg bram-vdberg marked this pull request as ready for review November 11, 2024 13:43
@bram-vdberg
Copy link
Collaborator Author

Shouldn't the readme file be updated as well here?

Thanks, I updated the readme

@bram-vdberg bram-vdberg merged commit a8ab231 into dev Nov 11, 2024
@bram-vdberg bram-vdberg deleted the setup_pip branch November 11, 2024 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants