Fix MEV Blocker kickbacks test #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisang
changed the title
fhenneke
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fhenneke observed that high MEV Blocker refund alerts were missing. Had a look and it turns out that a topic check
started failing because the left-hand side didn't have the prefix "0x".
Not sure why this stopped working, but in any case, this PR proposes a slightly more robust way of doing the check.
Also added a test to demonstrate the fix works. Again, the only meaningful way of running the test is by having it print the logs as well
python -m pytest --log-cli-level=DEBUG tests/e2e/mev_blocker_kickbacks_test.py