Update dependencies #934
Update dependencies #934
Conversation
| myMethod(invalid) as my_method; | ||
| myMethod(invalid invalid) as my_method; |
There was a problem hiding this comment.
rust-ethereum/ethabi#254
Plain invalid does not error anymore.
ethcontract/src/log.rs
Outdated
| let start_block = block_number(&web3, from_block).await?; | ||
| let end_block = block_number(&web3, to_block).await?; |
There was a problem hiding this comment.
Wasn't sure what the best way to handle the new BlockNumber::Finalized and BlockNumber::Safe was. So I moved all non number block numbers to be fetched by the node. This is a risky change because I'm not sure to what degree the exact behavior matters.
There was a problem hiding this comment.
This seems slightly incorrect to me.
For logs, to_block can be past the latest, so it shouldn't error in that case. I would implement this as:
let start_block = match from_block {
BlockNumber::Earliest => Some(0),
BlockNumber::Number(value) => Some(value.as_u64()),
BlockNumber::Latest | BlockNumber::Pending => None,
BlockNumber::Safe | BlockNumber::Finalized => block_number(&web3, from_block).await?,
};
let end_block = match to_block {
BlockNumber::Earliest => None,
BlockNumber::Number(value) => Some(value.as_u64()),
BlockNumber::Latest | BlockNumber::Pending => {
let latest_block = web3.eth().block_number().await?;
Some(latest_block.as_u64())
}
BlockNumber::Safe | BlockNumber::Finalized => block_number(&web3, to_block).await?,
};There was a problem hiding this comment.
Changed to your suggestion.
| ONE_KEY.into() | ||
| SecretKey::from_str("0000000000000000000000000000000000000000000000000000000000000001") | ||
| .unwrap() | ||
| .into() |
There was a problem hiding this comment.
nlordell
left a comment
nlordell
left a comment
There was a problem hiding this comment.
Looks good. One comment about the event loop implementation.
Went through all outdated dependencies and updated them.
(I got annoyed at some outdated dependencies in services.)
Test Plan
CI