Turn U256::from to U256::from_big_endian #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
commented
Aug 3, 2023
| // By converting and encoding U256, we get rid of the leading zeros. | ||
| encoder.append(&U256::from(signature.r.as_bytes())); | ||
| encoder.append(&U256::from(signature.s.as_bytes())); | ||
| encoder.append(&U256::from_big_endian(signature.r.as_bytes())); |
Contributor
Author
There was a problem hiding this comment.
unfortunately H256 doesn't have as_big_endian (to make it clear that this is indeed compatible). Have to rely on the docs https://rust.velas.com/primitive_types/struct.H256.html#note
Contributor
There was a problem hiding this comment.
Since H256 is just a [u8; 32], I don't think a concept of endianness makes sense... It is 32 bytes, so they are in byte order. At least this is my mental model around endianness.
Contributor
Agreed. This was mostly about |
nlordell
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes @nlordell comment on #944
I don't think it's worth releasing a version with this, as the U256 from bytes documentation ensures it's always interpreted as big endian: https://docs.rs/uint/latest/src/uint/uint.rs.html#1363
Test Plan
KMS example still works