Reduce minor compilation warnings #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
force-pushed
the
reduce-compilcation-warnings
branch
from
337a89e to
1f8136b
Compare
MartinquaXD
reviewed
Nov 15, 2023
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
There is not much development happening in this repo. That's why I would suggest also bumping the crate's version number in this PR so we can immediately import the fixed version in the services repo.
| .unwrap_or(&err.message) | ||
| } | ||
|
|
||
| #[allow(unused)] |
Contributor
There was a problem hiding this comment.
Are these allowed(unused) actually needed?
I believe we are exporting these types from the library clippy shouldn't care about them being used in the crate code.
Contributor
Author
There was a problem hiding this comment.
But for some reason, clippy shows unused warnings, probably because I use it with the --all-targets flag.
MartinquaXD
approved these changes
Nov 17, 2023
squadgazzz
added a commit
to cowprotocol/services
that referenced
this pull request
Nov 22, 2023
# Description Reduces Rust compilation warnings. Remaining warnings related to generated smart contracts will be fixed in cowprotocol/ethcontract-rs#964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates minor compilation warnings while using the generated smart contracts: