Skip to content

Conversation

@fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Mar 12, 2024

Description

Just a draft PR with all experimental changes to make same-token orders work, built with the valuable help of @harisang and @fhenneke.

A local forked-node setup on mainnet with the baseline solver:

  • Returns quotes for same-token orders with reasonable fee.
  • Allows creating orders with same buy and sell token.
  • Fills orders if the specified fee amount is that returned by the quote. The filled fee is consistent with the current gas price.

Note that the code is very horrible and any change is just there to make things work.
There are many things that should be carefully considered in an actual PR for this feature, notably PriceEstimating::estimate should probably split into two functions based on the purpose of the price estimation.

@github-actions
Copy link

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants