[PoC] Working support for transfers (don't merge!) #2513
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a draft PR with all experimental changes to make same-token orders work, built with the valuable help of @harisang and @fhenneke.
A local forked-node setup on mainnet with the baseline solver:
Note that the code is very horrible and any change is just there to make things work.
There are many things that should be carefully considered in an actual PR for this feature, notably
PriceEstimating::estimateshould probably split into two functions based on the purpose of the price estimation.