-
Notifications
You must be signed in to change notification settings - Fork 154
# Add Balancer V3, Uniswap V3, and Permit2 Support for Plasma Chain #3908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
29cb7af to
c92dd17
Compare
c92dd17 to
db12904
Compare
crates/contracts/src/alloy.rs
Outdated
| // not official | ||
| LENS => address!( "0xc3A5b857Ba82a2586A45a8B59ECc3AA50Bc3D0e3"), | ||
| LINEA => address!("0x31FAfd4889FA1269F7a13A66eE0fB458f27D72A9"), | ||
| PLASMA => address!("0xcb2436774C3e191c85056d248EF4260ce5f27A9D"), // Contract Name: BulbaV3Factory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does it say BulbaV3Factory? On the explorer it shows up as UniswapV3Factory for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked up these Uniswap v3 addresses from Okta trade's website, these are their deployments, and not actually deployed by the official uniswap team. There it mentioned the name BulbaV3Factory.
But you're right, since the explorer and the verified code sayds UniswapV3Factory, so I will remove this comment
db12904 to
70142b1
Compare
Add deployment address for BalancerV3BatchRouter on Plasma (chain ID 9745). Plasma only supports Balancer V3, not V2. Changes: - Add BalancerV3BatchRouter deployment for Plasma at 0x85a80afee867aDf27B50BdB7b76DA70f1E853062 (block 782312) - Update all Balancer V2 contract comments to indicate unavailability on Plasma and Linea - Add test assertion for BalancerV3BatchRouter on Plasma Plasma does not have Balancer V2 contracts (Vault, Queries, or any pool factories). Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Add Balancer V3, Uniswap V3, and Permit2 deployments for Plasma (9745). Mark Balancer V2 contracts as unavailable on Plasma and Linea. Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Rebase and move changes from alloy.rs to new location at build.rs Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
70142b1 to
4e190c5
Compare
Description
Add Balancer V3, Uniswap V3, and Permit2 Support for Plasma Chain
Plasma does not have Balancer V2 contracts deployed.
Changes
✅ Balancer V3
0x85a80afee867aDf27B50BdB7b76DA70f1E853062782312✅ Uniswap V3
0xaa52bB8110fE38D0d2d2AF0B85C3A3eE622CA455(marked as "not official")0x807F4E281B7A3B324825C64ca53c69F0b418dE40(marked as "not official")0xcb2436774C3e191c85056d248EF4260ce5f27A9D(named BulbaV3Factory, but same ABI and logic as UniswapV3Factory contract, checked manually)✅ Permit2
0x000000000022D473030F116dDEE9F6B43aC78BA3(found on okta trade)35701901📝 Updated
🧪 Testing
test_has_address()to verify:This PR enables the solver to route trades on Plasma using both Balancer V3 and Uniswap V3 protocols.
Sources for Addresses :-