Don't solve empty auctions #3915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a safeguard to prevent empty auctions from being sent to solvers after preprocessing. When all orders are filtered out during preprocessing (e.g., due to bad tokens, insufficient balance, or unsupported features), the auction becomes empty and there's no value in sending it to solvers for solving.
- Early return added when no orders remain after preprocessing
- Clear logging message indicates when this occurs
- Returns
Ok(None)to indicate no solution was found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tamir-cow
approved these changes
Nov 23, 2025
jmg-duarte
approved these changes
Nov 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a chance that after preprocessing, the auction can become empty due to filtering out orders for specific reasons. It doesn't make sense to send this kind of auction to solvers. One of the solvers already reported about this on BNB.