-
Notifications
You must be signed in to change notification settings - Fork 151
[TRIVIAL] Migrate DTOs and validation to alloy types #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate types from ethcontract's primitive_types to alloy::primitives across DTOs, database layer, and validation: - Replace H160 with Address in all DTOs and traits - Replace U256 with alloy::primitives::U256 where needed - Add IntoAlloy conversions in autopilot run loop - Update database helpers to use alloy-specific conversions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
MartinquaXD
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the migration from the
ethcontractlibrary to thealloylibrary by updating DTOs, database layer, andvalidation logic to use alloy primitive types. This is part of a larger effort to modernize the codebase's Ethereum
interaction layer.
The changes replace
primitive_types::{H160, U256}with their alloy equivalents (alloy::primitives::{Address, U256})across DTOs, API models, and validation traits, adding necessary type conversions where needed.
Changes
solver_competitionmodel types from H160/U256 to Address/alloy::U256IntoAlloyconversions for solver settlement dataLimitOrderCountingtrait to useAddressinstead ofH160.into_alloy()conversions in order validation logicAddress::repeat_byte,U256::from)How to test
Existing tests