[SIMPLE] Alloy migration for quotes, order validation, fee calculations #3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate types from ethcontract's primitive_types to alloy::primitives across DTOs, database layer, and validation: - Replace H160 with Address in all DTOs and traits - Replace U256 with alloy::primitives::U256 where needed - Add IntoAlloy conversions in autopilot run loop - Update database helpers to use alloy-specific conversions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…der validation, and fee calculations
jmg-duarte
changed the title
MartinquaXD
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-trivial part: https://github.com/cowprotocol/services/pull/3921/files#diff-3f8b6079ce50ae3ab0fe449d91c7e68922cae4023902961c892b58f91ddc49b3L148-L155
The rest is trivial
Description
This PR continues the migration from the
ethcontractlibrary to thealloylibrary by replacingprimitive_types(H160, U256) withalloy::primitives(Address, U256) across quote handling, order validation, solver competitions, DTOs, and database operations. This migration modernizes the codebase to use alloy's type system, which provides better type safety and compatibility with the latest Ethereum tooling.Changes
order_quotingmodule to use alloy U256 and Address types, updating Quote and QuoteData structuresorder_validationmodule to use alloy types for order validation logicsolver_competitionmodel with alloy Address and U256into_legacy()andinto_alloy()conversion helpers for backward compatibility where neededHow to test
Existing tests