[TRIVIAL] Migrate OrderQuoteRequest to use alloy Address types #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der validation, and fee calculations
jmg-duarte
changed the title
MartinquaXD
approved these changes
Nov 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
# Description Migrates `OrderQuoteRequest` struct from using ethcontract's `H160` to alloy's `Address` type for address fields (`from`, `sell_token`, `buy_token`, `receiver`). This is part of the ongoing ethcontract → alloy library migration. # Changes - [x] Update `OrderQuoteRequest` struct in `model/src/quote.rs` to use `alloy::primitives::Address` instead of `H160` - [x] Update `orderbook/src/api/post_quote.rs` tests to use alloy `Address` constructors - [x] Update `orderbook/src/quoter.rs` to handle alloy Address types - [x] Add `.into_legacy()` conversions in `shared/src/order_quoting.rs` when converting `OrderQuoteRequest` to `PreOrderData` (which still uses H160) - [x] Fix all e2e tests (14 files) to properly convert between H160 and alloy Address: - Use `.into_alloy()` when converting H160 → Address for OrderQuoteRequest - Use `.into_legacy()` when converting Address → H160 for legacy functions - Dereference address references where needed (`*token.address()`) ## How to test Existing tests <!-- ## Related Issues Fixes # --> --------- Co-authored-by: Claude <noreply@anthropic.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
OrderQuoteRequeststruct from using ethcontract'sH160to alloy'sAddresstype for address fields (from,sell_token,buy_token,receiver). This is part of the ongoing ethcontract → alloy library migration.Changes
OrderQuoteRequeststruct inmodel/src/quote.rsto usealloy::primitives::Addressinstead ofH160orderbook/src/api/post_quote.rstests to use alloyAddressconstructorsorderbook/src/quoter.rsto handle alloy Address types.into_legacy()conversions inshared/src/order_quoting.rswhen convertingOrderQuoteRequesttoPreOrderData(which still uses H160).into_alloy()when converting H160 → Address for OrderQuoteRequest.into_legacy()when converting Address → H160 for legacy functions*token.address())How to test
Existing tests