Use FuturesUnordered when fetching COW AMM balances
#3924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
changed the title
FuturesUnordered when fetching COW AMM balances
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the performance of COW AMM balance fetching on Base by replacing join_all (which uses FuturesOrdered for >30 futures) with FuturesUnordered. This change allows futures to complete in any order, improving concurrency when checking a high number of AMMs for zero token balances.
Key changes:
- Replaced
join_allwithFuturesUnorderedfor concurrent balance checking - Refactored async closure to use
async moveblock for better ownership handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmg-duarte
approved these changes
Nov 26, 2025
fafk
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetching COW AMM token balances takes a lot of time on base due to a high number of AMMs. In order to speed things up a bit, it is suggested to use
FuturesUnordered, which is a better approach thanFuturesOrdered, which is used byfutures_util::future::join_allwhen the number of futures exceeds 30.How to test
Staging