[TRIVIAL] Migrate order, quote, and validation modules to alloy #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate types from ethcontract's primitive_types to alloy::primitives across DTOs, database layer, and validation: - Replace H160 with Address in all DTOs and traits - Replace U256 with alloy::primitives::U256 where needed - Add IntoAlloy conversions in autopilot run loop - Update database helpers to use alloy-specific conversions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…der validation, and fee calculations
jmg-duarte
changed the title
jmg-duarte
changed the title
Contributor
|
I converted it to a draft to avoid notifications noise until all the issues with this PR are solved. |
MartinquaXD
approved these changes
Nov 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large but overall trivial
Description
This PR continues the migration from the deprecated
ethcontractlibrary to the modernalloylibrary by converting order, quote, and validation-related modules to use alloy primitive types (Address,U256).This is part of a broader effort to modernize the codebase and adopt alloy as the standard Ethereum library, replacing ethcontract's
H160andU256types with their alloy equivalents.Changes
Model layer
QuoteAmountsstruct to usealloy::primitives::U256incrates/model/src/order.rswithin_marketmethod by removing manual byte conversionsOrderQuoteRequest,OrderQuote,OrderQuoteResponseto usealloy::primitives::Addressincrates/model/src/quote.rsShared layer
QuoteParameters,Quote, andQuoteDatastructs to alloy types incrates/shared/src/order_quoting.rswidening_mulinstead offull_mulAmountsstruct and validation logic incrates/shared/src/order_validation.rsis_order_outside_market_priceto use typedwidening_mulcallsOrderbook layer
Autopilot
E2E tests
Addresscreation methods (with_last_byteinstead offrom_low_u64_be)Math utilities
How to test
Existing tests