[TRIVIAL] Migrate zeroex to use alloy bytes types #3931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
approved these changes
Nov 28, 2025
Contributor
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
LGTM overall but some notes
Comment on lines
412
to
432
| IZeroex::LibNativeOrder::LimitOrder { | ||
| makerToken: zeroex_order.order().maker_token.into_alloy(), | ||
| takerToken: zeroex_order.order().taker_token.into_alloy(), | ||
| makerToken: zeroex_order.order().maker_token, | ||
| takerToken: zeroex_order.order().taker_token, | ||
| makerAmount: zeroex_order.order().maker_amount, | ||
| takerAmount: zeroex_order.order().taker_amount, | ||
| takerTokenFeeAmount: zeroex_order.order().taker_token_fee_amount, | ||
| maker: zeroex_order.order().maker.into_alloy(), | ||
| taker: zeroex_order.order().taker.into_alloy(), | ||
| sender: zeroex_order.order().sender.into_alloy(), | ||
| feeRecipient: zeroex_order.order().fee_recipient.into_alloy(), | ||
| pool: zeroex_order.order().pool.into_alloy(), | ||
| maker: zeroex_order.order().maker, | ||
| taker: zeroex_order.order().taker, | ||
| sender: zeroex_order.order().sender, | ||
| feeRecipient: zeroex_order.order().fee_recipient, | ||
| pool: zeroex_order.order().pool, | ||
| expiry: zeroex_order.order().expiry, | ||
| salt: zeroex_order.order().salt.into_alloy(), | ||
| }, | ||
| IZeroex::LibSignature::Signature { | ||
| signatureType: zeroex_order.order().signature.signature_type, | ||
| v: zeroex_order.order().signature.v, | ||
| r: zeroex_order.order().signature.r.into_alloy(), | ||
| s: zeroex_order.order().signature.s.into_alloy(), | ||
| r: zeroex_order.order().signature.r, | ||
| s: zeroex_order.order().signature.s, | ||
| }, | ||
| zeroex_order.order().taker_amount, |
Contributor
There was a problem hiding this comment.
With all these .order() I wonder if we couldn't just make a function that returns a tuple with these 3 args and hides the .order() calls under a single one inside
Contributor
Author
There was a problem hiding this comment.
I ended up going with let order = zeroex_order.order() and referenced that variable instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates zereox related logic to use alloy's bytes types (Address, B256). I didn't touch the
U256types yet since they tend to be more complicate.How to test
existing e2e tests