Fixes refunder failures on Sepolia #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused by orders whose owners cannot receive ETH. When such orders are included in a batch, the entire transaction reverts with `EthTransferFailed`, blocking valid orders from being refunded.
squadgazzz
reviewed
Nov 28, 2025
extrawurst
deleted the
fix-refunder-issue-when-receiver-is-a-contract-that-cannot-receive-funds
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The refunder fails when batches contain orders whose owners cannot receive ETH (e.g., EOF contracts). This causes the entire batch to revert with
EthTransferFailed, blocking valid refunds and triggering gas price escalation.Note: This issue currently affects Sepolia where EOF (EVM Object Format) contracts exist. EOF is not yet deployed on mainnet.
Root Cause
The EthFlow contract uses push-based refunds that require owners to accept ETH. When any owner in a batch rejects the transfer, the entire transaction reverts.
Solution
Added
can_receive_eth()that uses gas estimation to detect addresses that cannot receive ETH. Orders with non-receivable owners are marked as "Invalid" and filtered out before batching, following the existing zero-owner filtering pattern.This filter applies to any contract that rejects ETH (missing receive/fallback, or EOF contracts), not just EOF-specific cases.
Verification
The problematic Sepolia EOF contract can be verified: