Remove autopilot::domain::eth::Address in favor of alloy::primitives::Address #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jmg-duarte
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
# Description
This PR migrates the codebase from using `primitive_types::H160` to
`alloy::primitives::Address` for representing Ethereum addresses. This
migration aligns the codebase with the alloy ecosystem and removes
dependency on the legacy primitive_types crate for address handling.
# Changes
- [x] Replace `H160` imports with `Address` from `alloy::primitives`
across the codebase
- [x] Update `BUY_ETH_ADDRESS` constant to use
`Address::repeat_byte(0xee)` instead of `H160([0xee; 20])`
- [x] Update address comparisons and conversions throughout:
- Remove `.as_slice()` comparisons in favor of direct equality checks
- Add/update `.into_alloy()` and `.into_legacy()` conversions where
needed
- Remove unnecessary conversions where types already match
- [x] Update function signatures to accept/return `Address` instead of
`H160`:
- Database operations (auction_prices.rs)
- Price estimation modules (native_price_cache.rs, factory.rs, etc.)
- Account balance queries and operations
- Order validation and processing
- Settlement encoding
- [x] Update test fixtures and assertions to use `Address` types
- [x] Clean up conversion logic to eliminate redundant type conversions
## How to test
Existing tests
<!-- GitButler Footer Boundary Top -->
---
This is **part 1 of 2 in a stack** made with GitButler:
- <kbd> 2 </kbd> #3934
- <kbd> 1 </kbd> #3932 👈
<!-- GitButler Footer Boundary Bottom -->
jmg-duarte
force-pushed
the
jmgd/alloy/eth-address
branch
from
4b78423 to
f909260
Compare
MartinquaXD
reviewed
Nov 28, 2025
| pub struct Competition { | ||
| pub auction_id: AuctionId, | ||
| pub reference_scores: HashMap<eth::Address, Score>, | ||
| pub reference_scores: HashMap<Address, Score>, |
Contributor
There was a problem hiding this comment.
IMO it still makes sense to have the Address as a domain type so I would suggest to re-export the type from the eth module instead of pulling most basic types from eth and only Address from alloy directly.
MartinquaXD
approved these changes
Dec 1, 2025
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
LGTM. I don't see anything in the PR that would cause the failing test. Seems like regular flakiness that needs to be investigated separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the eth::Address structure in favor of the alloy::primitives::Address
Changes
How to test
Existing tests
This is part 2 of 2 in a stack made with GitButler: