Migrate OrderCreation and signature handling to alloy types #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Dec 1, 2025
squadgazzz
reviewed
Dec 1, 2025
crates/e2e/tests/e2e/liquidity.rs
Outdated
Comment on lines
311
to
312
| maker_amount: order_creation.buy_amount.try_into().unwrap(), | ||
| taker_amount: order_creation.sell_amount.try_into().unwrap(), |
Contributor
There was a problem hiding this comment.
Where did multiplication go?
Contributor
Author
There was a problem hiding this comment.
Oooof great catch, this was probably migrated by Claude
m-sz
reviewed
Dec 5, 2025
Contributor
m-sz
left a comment
m-sz
left a comment
There was a problem hiding this comment.
LGTM except for the missed multiplication as pointed out by @squadgazzz, will be happy to approve once it's fixed.
squadgazzz
approved these changes
Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the migration from ethcontract types to alloy primitives, focusing on order
creation, signature handling, and test infrastructure. This is part of the broader effort to
adopt alloy as the primary Ethereum library across the codebase.
The changes primarily affect the e2e test suite and related infrastructure, migrating from
ethcontract::H160andethcontract::U256toalloy::primitives::Addressandalloy::primitives::U256respectively.Changes
OrderCreationfields to use alloyAddressandU256types.into_legacy()conversions whereneeded
to_wei()witheth()helper throughout e2e testscolocation.rs,solution.rs) to use alloyAddressservices.rsto accept alloy addresses.into_alloy()conversions where values are already alloy typesHow to test
Existing tests