Enable UniswapV3 baseline source for Plasma chain #3944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BaselineSource::UniswapV3 to Plasma chain's default baseline sources - Fix PoolData ID formatting to use hex representation with 0x prefix Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
fafk
approved these changes
Dec 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes subgraph pagination failure when fetching UniswapV3 pools from Goldsky-hosted subgraph on Plasma.
The driver was failing to initialize UniswapV3 liquidity with error:
This error originated from the subgraph (not our Rust code) when processing paginated queries.
Root Cause
PoolData::get_id()incrates/shared/src/sources/uniswap_v3/graph_api.rs:308:4-311:5usedH160::to_string()which produces a truncated display format:When this truncated ID was passed as
lastIdfor pagination (id_gt: $lastId), the subgraph failed to parse it as a validBytestype due to the ellipsis creating an odd number of hex digits.Fix
Changed
self.id.to_string()toformat!("{:#x}", self.id)which produces the full 42-character hex string:Testing