-
Notifications
You must be signed in to change notification settings - Fork 154
Return deadline block in the solver competition V2 API #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reminder: Please consider backward compatibility when modifying the API specification.
Caused by: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the auction deadline block to the solver competition V2 API response, enabling easier computation of solver rewards and extending circuit breaker functionality to detect solvers executing after the deadline.
- Exposes the existing
deadlinefield from the database through all API layers - Updates the API response structure and OpenAPI documentation with the new field
- Adds appropriate test coverage for the new field
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/database/src/solver_competition_v2.rs | Added deadline field to Auction struct and updated SQL query to fetch it from competition_auctions table |
| crates/orderbook/src/database/solver_competition_v2.rs | Mapped auction.deadline from database to auction_deadline_block in API response |
| crates/model/src/solver_competition_v2.rs | Added auction_deadline_block field to Response struct with proper serialization and updated tests |
| crates/orderbook/openapi.yml | Documented the new auctionDeadlineBlock field in the API specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Adds the auction deadline block to the solver competition V2 API as requested in #3947:
How to test
Adjusted existing tests.
Related Issues
Fixes #3947