Migrate the rest of the solver(s) crates to alloy #3959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
force-pushed
the
jmgd/alloy/solver
branch
from
08e822a to
b3ea6ca
Compare
jmg-duarte
force-pushed
the
jmgd/alloy/solvers
branch
2 times, most recently
from
14d5803 to
0c3728b
Compare
jmg-duarte
force-pushed
the
jmgd/alloy/solvers
branch
from
0c3728b to
d4ffa3b
Compare
jmg-duarte
changed the title
m-sz
reviewed
Dec 10, 2025
m-sz
reviewed
Dec 10, 2025
m-sz
reviewed
Dec 10, 2025
Contributor
m-sz
left a comment
m-sz
left a comment
There was a problem hiding this comment.
Overall looks good to me. There are some inconsistencies around using U256::ONE and U256::from(1), and the question regarding adding .expect() when migrating from as_u128()
Contributor
|
As we are not introducing any new panics, I do not lean strongly on You having to change U256::from(1) to U256::ONE. |
m-sz
approved these changes
Dec 10, 2025
squadgazzz
approved these changes
Dec 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the rest of the solver and solvers crates to alloy
Changes
How to test
Existing tests