Skip to content

Conversation

@MartinquaXD
Copy link
Contributor

@MartinquaXD MartinquaXD commented Dec 10, 2025

Description

This test appears to be flaky due to a bug in the new auction notficiation logic. It was introduced to avoid busy looping. Now we only start new auctions when we see a new block or a new order. However, so far we first updated the caches and then waited for the notification. This doesn't make a lot of sense since the notification indicates that the cache needs to be updated.
This resulted in test runs where we:

  1. update the cache
  2. see new order
  3. start auction
  4. skip empty auction because cache didn't include the order of step 2

Changes

Updated the autopilot to only update the cache after receiving the signal to start a new auction

How to test

Run flaky test runner on local_node_non_settling_solver (run)

@MartinquaXD MartinquaXD requested a review from a team as a code owner December 10, 2025 10:03
@MartinquaXD MartinquaXD added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit ed095d4 Dec 10, 2025
18 checks passed
@MartinquaXD MartinquaXD deleted the build-cache-after-invalidation branch December 10, 2025 11:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants