fix flaky test: local_node_non_settling_solver
#3962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test appears to be flaky due to a bug in the new auction notficiation logic. It was introduced to avoid busy looping. Now we only start new auctions when we see a new block or a new order. However, so far we first updated the caches and then waited for the notification. This doesn't make a lot of sense since the notification indicates that the cache needs to be updated.
This resulted in test runs where we:
2Changes
Updated the autopilot to only update the cache after receiving the signal to start a new auction
How to test
Run flaky test runner on
local_node_non_settling_solver(run)