Migrate remaining_amounts module to alloy #3968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sz
approved these changes
Dec 11, 2025
jmg-duarte
force-pushed
the
jmgd/alloy/remaining
branch
from
88acad1 to
d8e7b42
Compare
jmg-duarte
force-pushed
the
jmgd/alloy/remaining
branch
from
4d35dd4 to
ec80107
Compare
MartinquaXD
approved these changes
Dec 12, 2025
Comment on lines
+14
to
+17
| /// Multiplies a ratio by a scalar, returning `None` only if the result | ||
| /// would overflow a `U256`, but intermediate operations are allowed to | ||
| /// overflow. | ||
| fn full_scalar_mul(&self, scalar: N) -> Option<N>; |
Contributor
There was a problem hiding this comment.
With alloy's number types being so efficient I wonder if this shouldn't just be the default behavior.
Usually the only reason why one would want intermediate overflows to cause errors is when you try to model the behavior of a smart contract that does that. This is not the case here.
Fine to merge without addressing this since this is a faithful conversion of the existing code.
Contributor
Author
There was a problem hiding this comment.
Default behaviour for what though?
squadgazzz
approved these changes
Dec 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the remaining_amounts module to alloy.
Note: a big chunk of the diff was just moving the Remaining impl closer to the struct, the diff is just eh at noticing.
Changes
How to test
Existing tests