[TRIVIAL] Unify eth monetary units #3970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sz
reviewed
Dec 11, 2025
Contributor
m-sz
left a comment
m-sz
left a comment
There was a problem hiding this comment.
Small nits, otherwise it looks good!
I like how the extension trait makes the amounts read naturally: 1 ETH, 1 WEI, etc.
m-sz
approved these changes
Dec 11, 2025
jmg-duarte
changed the title
fafk
reviewed
Dec 12, 2025
MartinquaXD
approved these changes
Dec 12, 2025
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
Didn't spot any wrong number conversions.
No strong preference on the USDC comment so I'm fine with merging without resolving that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unifies ethereum units under one API
Changes
to_wei,to_wei_with_exp,ethand theUnit::XapproachesHow to test
Existing tests