Migrate autopilot to alloy #3972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
reviewed
Dec 11, 2025
Contributor
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
TokenAddress is ok, BlockId -> BlockNumber are not the same so I'm curious to know your reasoning
| &self, | ||
| prospective_solver: eth::Address, | ||
| block: BlockId, | ||
| block: BlockNumber, |
Contributor
There was a problem hiding this comment.
BlockNumber is arguably more correct, though. Also the existing code converted a specific block number to the block id so the new code is still functionally equivalent.
MartinquaXD
approved these changes
Dec 12, 2025
squadgazzz
reviewed
Dec 12, 2025
BlockNumber -> BlockId
Contributor
Author
|
Changed BlockNumber -> BlockId as per the comments. Not yet convinced to change TokenAddress to just Address. |
jmg-duarte
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates most of the autopilot crate to alloy. The only leftover is the
src/database/events.rsfile, mentioning EventMetadata which would require a wider migration of the event streaming, filtering and parsing machinery inshared/event_handling.rsChanges
Changes ethcontract types H160, U256, BlockId to corresponding alloy types (Address, B256, BlockNumber)
How to test
unit tests, e2e tests.