Drop heaptrack profiler support #3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes heaptrack profiler support from the codebase, effectively reverting changes from PR #2800. Since the tikv-jemalloc profiler is now being used (as mentioned in #3923), heaptrack is no longer needed.
Key changes:
- Removed heaptrack installation and build steps from both Dockerfiles
- Deleted the entrypoint.sh wrapper script that provided optional heaptrack profiling
- Simplified final stage setup to only install netcat-openbsd without heaptrack dependencies
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Dockerfile | Removed heaptrack build dependencies and installation, removed entrypoint.sh copying and CMD declaration |
| playground/Dockerfile | Removed heaptrack build dependencies and installation, removed entrypoint.sh copying and CMD declaration |
| entrypoint.sh | Deleted the heaptrack wrapper script entirely |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MartinquaXD
approved these changes
Dec 12, 2025
jmg-duarte
approved these changes
Dec 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
tikv-jemallocprofiler is now used(#3923), the heaptrack support can be removed. This PR basically reverts #2800.