[TRIVIAL] Fix clippy warnings #3974
Merged
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses clippy warnings introduced by a recent Rust/Clippy update by removing unnecessary cloning and improving error message informativeness.
- Removed redundant
.cloned()call in iterator chain where the called method only needs a reference - Enhanced error message to include the fee amount value that was previously not displayed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/shared/src/trade_finding/mod.rs |
Removed unnecessary .cloned() in map_interactions_data since to_interaction_data() only requires a reference |
crates/shared/src/order_quoting.rs |
Added fee_amount field to error message format string to display the actual fee value in errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fafk
approved these changes
Dec 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes clippy warnings due to the latest update.
Failed CI: https://github.com/cowprotocol/services/actions/runs/20142706161/job/57814513611?pr=3973