Clean up usage of ethcontract exports #3981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Dec 16, 2025
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
LGTM besides the dependency question.
| url = { workspace = true } | ||
| web3 = { workspace = true } | ||
| mockall = { workspace = true, optional = true } | ||
| jsonrpc-core.workspace = true |
Contributor
There was a problem hiding this comment.
Is there a particular reason this doesn't use the same formatting as every other dependency?
Contributor
There was a problem hiding this comment.
Also why do we need this dependency here in the first place? I don't see this being used anywhere in the PR. Is this similar to the feature unification issue where building some crates required them to be built together with some other crates?
Contributor
Author
There was a problem hiding this comment.
About the formatting, I added it using cargo add so it came out like that. IMO we should use a formatter for the TOMLs too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the usage of ethcontract exports, this makes it easier to track the migration progress
Changes
How to test
Existing tests