-
Notifications
You must be signed in to change notification settings - Fork 153
Migrate RPC calls into alloy #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Well, this change might affect the performance. It would be great to test it on prod as well and probably release it separately as a hotfix. |
MartinquaXD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are no old chain_id() calls left could you please also update our custom clippy lint.
Is there anything specific you worry about? The PR looks pretty innocent to me. |
I assume the RPC calls in the indexers are migrated to alloy. Not sure how it will behave. |
squadgazzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for running the tests ❤️
Description
Migrates almost all RPC calls to the alloy provider. As far as I can tell, the only remaining ones are related to the access lists which require more attention.
There are others missing because they use the
transportvariable and I was only searching forweb3; I'll leave it for another PRChanges
How to test
Existing tests + staging