-
Notifications
You must be signed in to change notification settings - Fork 151
Unify mempool configs #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify mempool configs #3983
Conversation
squadgazzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Does it make sense to add the mempool name into this config services/crates/driver/src/infra/mempool/mod.rs Lines 15 to 25 in 8440650
, so its name will be logged in this span?
UPD, it should probably be a part of the kind then:
|
|
Each mempool already has a name. Logging it happens via the |
|
I somehow missed that, thanks! |
jmg-duarte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I have a question
Description
Especially on gnosis chain the reference driver struggled to bring solutions on chain. The issue seems to have been poor transaction gossiping of the 1 configured RPC. The fix was to configure multiple mempools at once. This ended up looking pretty weird with the current code because the only way how you can configure an RPC URL explicitly is by using the mevblocker variant of the mempool enum. This doesn't make sense since a) there is no mevblocker on gnosis chain and b) even on mainnet there is only 1 mevblocker.
Changes
This PR removes the
mempoolenum and replaces it with a struct that is flexible enough to configure an actual mevblocker endpoint but also multiple regular RPC nodes.Since this is changing the driver config file in a backwards incompatible way this needs to be merged together with the corresponding infra PR updating the config format.
How to test
updated e2e and driver tests should still pass