Migrate primitive types in e2e crate to alloy (H256→B256, H160→Address) #3986
Conversation
AryanGodara
changed the title
AryanGodara
changed the title
|
I want to encourage good PR descriptions but having a wall of text to essentially say "replace ethcontract type with alloy version" doesn't seem that helpful. |
squadgazzz
left a comment
squadgazzz
left a comment
There was a problem hiding this comment.
LGTM. I have nothing to add to Martin's comments.
Let's just try to avoid overly verbose AI-generated PR descriptions in the future.
Yes, I was having trouble finding a common goal for this PR, it was basically migrating primitive types from ethcontract to alloy. But I'll refrain from asking the LLM to summarize the changes from now on 🫡 Fixing the changes for now, and pushing |
jmg-duarte
left a comment
jmg-duarte
left a comment
There was a problem hiding this comment.
LGTM small notes only
Replaces ethcontract H256 and H160 types with alloy B256 and Address types in e2e test setup and test files. Removes unnecessary IntoLegacy conversions when calling get_solver_competition, get_orders_for_tx, and get_orders_for_owner methods. Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Replaces ethcontract Address and H256 types with alloy Address and B256 types in e2e test setup and test files. Removes unnecessary IntoAlloy and IntoLegacy conversions throughout the codebase. Updates default_pool_code method to use B256::new constructor. Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
AryanGodara
force-pushed
the
aryan/migrate-e2e-h256-h160
branch
from
cbab82c to
fbe5849
Compare
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Description
Migrates
H256→B256andH160→Addressprimitive types in the e2e crate, removing unnecessary.into_alloy()and.into_legacy()conversions where alloy types are now used directly. Also addsEthUnittrait implementation forf64to enable cleaner fractional ETH expressions like0.1.eth()How to test