Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Dec 22, 2025

Description

Discussed in this thread: #4001 (comment)

This PR moves the impersonation mechanisms to alloy, the migrated ones are only impersonated in the specific transaction, no changes to the actual tests were needed.

Exposed the previous string oriented API under a trait to as discussed in a comment below.
Anvil provides an anvil specific API that we're not using unless necessary as these ones are more general

Changes

  • Migrate the last mine_pending_block
  • Migrate the other evm calls to the new trait
  • Migrate the last impersonations
  • Remove the forked_node and local_node modules

How to test

Existing tests

@jmg-duarte jmg-duarte changed the title Fully migrate impersonation to alloy Migrate evm_ APIs to alloy Dec 22, 2025
@jmg-duarte jmg-duarte changed the title Migrate evm_ APIs to alloy Migrate evm_ (impersonate, automine, etc) APIs to alloy Dec 22, 2025
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

@jmg-duarte jmg-duarte enabled auto-merge December 22, 2025 15:33
@jmg-duarte jmg-duarte added this pull request to the merge queue Dec 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 22, 2025
@jmg-duarte jmg-duarte enabled auto-merge December 22, 2025 15:51
@jmg-duarte jmg-duarte added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit 47610ab Dec 22, 2025
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy/forked_node branch December 22, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants