Skip to content

Conversation

@bosungpark
Copy link
Contributor

@bosungpark bosungpark commented Nov 26, 2024

Problem

There is a dependency conflict when using the library with other libraries that have incompatible versions of protobuf.

Task

Modify the protobuf dependency to support versions from 4.xx to 5.xx.
Fix any broken code due to compatibility issues between different versions.

Solution

Update the file to specify the compatible range of protobuf versions:
Ensure all code is compatible with the specified range of protobuf versions.

@@ -1,6 +1,6 @@
[tool.poetry]
name = "alignai"
Copy link
Contributor Author

@bosungpark bosungpark Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update version "0.3.1" -> "0.3.2"
update protobuf version "^5.28.1" -> ">=4.25.3,<6.0.0"

also updated buf schema

@bosungpark bosungpark self-assigned this Nov 26, 2024
@bosungpark bosungpark added the backend back-end related label Nov 26, 2024
@bosungpark bosungpark marked this pull request as ready for review November 26, 2024 10:58
@kde713 kde713 requested review from Copilot and kde713 November 27, 2024 06:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

@bosungpark bosungpark merged commit 7b962ac into main Nov 27, 2024
@bosungpark bosungpark deleted the feature/ALIGN-1014 branch November 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend back-end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants