Skip to content

feat: Update lint tools #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kde713 merged 4 commits into from
Mar 22, 2024
Merged

feat: Update lint tools #7

kde713 merged 4 commits into from
Mar 22, 2024

Conversation

@kde713
Copy link
Contributor

@kde713 kde713 commented Mar 22, 2024 •
edited
Loading

Summary

  • Update ruff, black, mypy, isort, pre-commit
  • This PR will also resolve CVE-2024-21503 (Does not affect on distribution, only dev dependencies)

Note

  • Didn't use latest version (v3.6.2) of pre-commit because it dropped python 3.8 support.

@kde713 kde713 requested a review from nyanxyz March 22, 2024 06:52
@kde713 kde713 self-assigned this Mar 22, 2024
nyanxyz
nyanxyz approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@nyanxyz nyanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kde713 kde713 merged commit 73efe60 into main Mar 22, 2024
@kde713 kde713 deleted the feature/update-lint branch March 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nyanxyz nyanxyz nyanxyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kde713 kde713

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kde713 @nyanxyz