Skip to content

GitHub workflows for build and testing#10

Merged
cozis merged 24 commits intocozis:devfrom
yonas-forks:github-workflows
Sep 26, 2024
Merged

GitHub workflows for build and testing#10
cozis merged 24 commits intocozis:devfrom
yonas-forks:github-workflows

Conversation

@yonas
Copy link
Copy Markdown
Contributor

@yonas yonas commented Sep 26, 2024

The tests/test.py exits with a Connection refused error in GitHub's CI, but works fine for me locally.

Here's the minuimum that works without error:

name: Testing

on:
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v4

    - name: make
      run: make

@cozis
Copy link
Copy Markdown
Owner

cozis commented Sep 26, 2024

Much appreciated! Can you change the PR target to the dev branch? I try to avoid pushing directly to main. We should probably include dev in the workflow too

@yonas
Copy link
Copy Markdown
Contributor Author

yonas commented Sep 26, 2024

I've added dev to the target branches. You'll want to include main so that people can easily see the results.

@yonas yonas force-pushed the github-workflows branch 5 times, most recently from 586624b to fc09343 Compare September 26, 2024 14:30
@cozis cozis changed the base branch from main to dev September 26, 2024 20:32
@cozis cozis merged commit e127458 into cozis:dev Sep 26, 2024
@yonas yonas deleted the github-workflows branch September 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants