feat: Allow io.cozy.contacts and io.cozy.contacts.groups in token exc…#4745
Merged
feat: Allow io.cozy.contacts and io.cozy.contacts.groups in token exc…#4745
Conversation
zatteo
force-pushed
the
feat/add-contacts-in-token-exchange
branch
2 times, most recently
from
f37d590 to
8427d13
Compare
shepilov
reviewed
May 4, 2026
| } | ||
| if req.Scope != tokenExchangeAllowedScope { | ||
| return nil, echo.NewHTTPError(http.StatusBadRequest, "invalid scope") | ||
| if err := validateTokenExchangeScope(req.Scope); err != nil { |
Contributor
There was a problem hiding this comment.
Could you please trim spaces before validation, and use stings.Split please, because later we use it, and with stings.Fields you allow tokens like io.cozy.files\tio.cozy.contact.
Or if you want a multiline support, you then need to use strings.Join(fields, " ") as scope, and return it from validation function, and then probably rename it
Member
Author
There was a problem hiding this comment.
Done. I let you check again and merge if it's okay 👍
shepilov
approved these changes
May 4, 2026
…hange Replace the single allowed scope constant with an allowlist and a validateTokenExchangeScope function that accepts any space-separated combination of io.cozy.files, io.cozy.contacts, and io.cozy.contacts.groups.
zatteo
force-pushed
the
feat/add-contacts-in-token-exchange
branch
from
8427d13 to
05f3b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hange
Replace the single allowed scope constant with an allowlist and a validateTokenExchangeScope function that accepts any space-separated combination of io.cozy.files, io.cozy.contacts, and io.cozy.contacts.groups.