Skip to content

feat: use Ctrl + mouse wheel to change the font#24

Merged
ouuan merged 1 commit intomasterfrom
wheel-change-font
Jul 4, 2020
Merged

feat: use Ctrl + mouse wheel to change the font#24
ouuan merged 1 commit intomasterfrom
wheel-change-font

Conversation

@ouuan
Copy link
Member

@ouuan ouuan commented Jun 30, 2020

No description provided.

@ouuan ouuan requested review from coder3101 and neko-para June 30, 2020 09:50
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat: use mouse wheel to change the font

Powered by Pull Assistant. Last update 082adb6 ... 082adb6. Read the comment docs.

@sonulohani
Copy link

sonulohani commented Jul 1, 2020

Hi @ouuan

I can verify from visual studio 2019 and vscode that when we zoom in or zoom out, it generally zoom-in/out the viewport and not increase/decrease font size. Can we have a small combo-box like this as well

image

Reference link for zoom-in/out the widget:- https://stackoverflow.com/questions/6650219/zooming-function-on-a-qwidget

@ouuan ouuan requested review from coder3101 and neko-para and removed request for coder3101 and neko-para July 3, 2020 03:07
@ouuan
Copy link
Member Author

ouuan commented Jul 4, 2020

@coder3101 @neko-para Any review?

@coder3101
Copy link
Member

I can verify from visual studio 2019 and vscode that when we zoom in or zoom out, it generally zoom-in/out the viewport and not increase/decrease font size.

It is true but what is the problem with increasing or decreasing the font size?

@neko-para
Copy link

I think it's ok to change font size directly.

Copy link
Member

@coder3101 coder3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on win10

@ouuan ouuan merged commit baf096a into master Jul 4, 2020
@ouuan ouuan deleted the wheel-change-font branch July 4, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants