Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
|
@ouuan Please review the PR or list down the issues, So I can acknowledge them or point if those could be solved. |
Member
|
Some problems:
|
ouuan
requested changes
Sep 4, 2020
ouuan
requested changes
Sep 4, 2020
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1. Statusbar now shows message in same font as Code Editor
2. Disable auto Parenthesis add/remove setting in vim mode. These
settings are not available in vim by default. Default vim does not
automatically closes or adds parenthesis. Read below
3. In QCodeEditor, *keypressEvents* are not handled in vim mode.
FakeVim automatically can handle special cases like Ctrl+Enter,
auto indenting, smart indenting. Since, parenthesis add/remove was
implemented by **intercepting keypressEvents**, it will not work.
4. Put default vimrc for users. It contains same behaving defaults as
normal editor.
4.1 Do not replace tabs with spaces
4.2 Tab stop is 4
4.3 Smart indent and auto-indent
5. Fixed the issue where vimrc changes of tab sizes were not being
updated by code editor.
Co-authored-by: coder3101 <coder3101@users.noreply.github.com>
Member
Author
|
This PR is ready for final review. I have fixed most of the issues you pointed. You can give it a try again and let me know if there are more changes required. |
Member
Author
|
Old documentation PR has been closed and a new one has been opened here cpeditor/cpeditor.github.io#115 |
Member
Author
|
Vim mode is for cpeditor 7.0 and has been ported to new code editor on #516 |
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Vi mode is very popular and is widely used by many programmers. It speeds up so many tasks and so those who are used to it, do not like to code on any other editor. This is stopping many from adapting CP Editor as their main Editor for competitive Programming. This PR adds support for Vi mode in the code Editor using a popular extension written by the authors of Qt Creator called FakeVim.
Related Issue
Motivation and Context
I like to code in Vim too and sometimes I don't like CP Editor because of it not having Vim Support.
How Has This Been Tested?
Screenshots (if appropriate)
N/A
Type of changes
Checklist
git resetand commit again, or usegit rebase -iandgit commit --amendto modify the commit messages.)tr()orQCoreApplication::translate().Checklist