Fix unstable batch exports on larger processes#40
Fix unstable batch exports on larger processes#40JusticeShultz wants to merge 2 commits intocpetry:gh-pagesfrom
Conversation
|
Overall it looks fine and I really appreciate your contribution! In your PR you created disposeRenderTarget() for ambient, displace and specular classes. I see a few other refactorings. The downloadImage() method in your PR returns a Promise. Why not using async function()? Also you refactored isSupportedImageFile() and isTargaFile(). Could you please do this as a separate PR to keep changes to the issue you are referring to in your PR? I'll approve once you updated |
|
@cpetry Changes made:
The PR should now only contain the batching fix and the related render target cleanup needed for stability. If you'd like, I can open the TGA/file handling cleanup as a separate PR. |
Batch mode was not reliably exporting all selected files. The download path fired multiple async saves without actually waiting for completion, so browsers would only allow some of the downloads through. The render pipeline was also creating new WebGL render targets during repeated batch processing without disposing old ones, which made larger batches increasingly unstable.
This PR: