Add timeout parameter to migration defined types#6
Open
alexjfisher wants to merge 1 commit intocpitman:masterfrom
Open
Add timeout parameter to migration defined types#6alexjfisher wants to merge 1 commit intocpitman:masterfrom
timeout parameter to migration defined types#6alexjfisher wants to merge 1 commit intocpitman:masterfrom
Conversation
Expose the `Exec` resource's `timeout` parameter in the flyway and liquibase migration defined types. This is better than setting a `Resource default statement` for Execs where the `Area of effect` can be problematic. See https://docs.puppet.com/puppet/latest/reference/lang_defaults.html#area-of-effect Tests, (and a few minor lint fixups) included. Signed-off-by: Alexander Fisher <alex@linfratech.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the
Execresource'stimeoutparameter in the flyway andliquibase migration defined types. This is better than setting a
Resource default statementfor Execs where theArea of effectcan beproblematic. See
https://docs.puppet.com/puppet/latest/reference/lang_defaults.html#area-of-effect
Tests, (and a few minor lint fixups) included.