[expected.object.general] Add missing noexcept for expected::error()#5381
Merged
jensmaurer merged 2 commits intocplusplus:mainfrom Apr 26, 2022
Merged
[expected.object.general] Add missing noexcept for expected::error()#5381jensmaurer merged 2 commits intocplusplus:mainfrom
jensmaurer merged 2 commits intocplusplus:mainfrom
Conversation
Member
|
@jwakely, this looks like an oversight in the incoming paper. Do you think this is editorial, or does it need an LWG issue? Note: squash and fix commit message when merging |
Member
|
@jwakely , ping. |
Member
|
I don't recall the intention or whether we discussed making these narrow contact functions noexcept. I'll check the minutes. |
Member
|
The
It looks like we agreed to add it then, but it wasn't added to the synopsis. So I think this can be fixed editorially. |
jwakely
approved these changes
Apr 26, 2022
jensmaurer
approved these changes
Apr 26, 2022
StephanTLavavej
added a commit
to miscco/STL
that referenced
this pull request
May 20, 2022
Thanks to cplusplus/draft#5381 , this shouldn't be marked as strengthened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [expected.object.general], the function is defined as
constexpr const E& error() const &;However in [expected.object.obs], it is defined as
constexpr const E& error() const & noexcept;So let me assume it's just that the author of the paper forgot to add
noexcept.