Compare HUNTER_GATE_SHA1 after TOLOWER #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't depend on sha1sum being created with the same capitalization in HunterGate. Do it the same way as in `hunter_make_directory`, which converts all alphabetical character to lower-case before comparing the sha1-strings.
Author
|
@rbsheth ping |
rbsheth
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't depend on sha1sum being created with the same capitalization in HunterGate.
Do it the same way as in
hunter_make_directory[1], which converts all alphabeticalcharacter to lower-case before comparing the sha1-strings.
[1] https://github.com/cpp-pm/hunter/blob/3b5ce35e418840e080cf6c68accadd70ea31fb58/cmake/modules/hunter_make_directory.cmake#L29
edit: reason for this PR: on Windows the SHA1 sum suddenly didn't compare right anymore because capitalization was different between generated sha1 sum and user provided sha1